Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inline namespace for global helpers #58

Merged
merged 3 commits into from
Dec 19, 2021

Conversation

nolde
Copy link
Contributor

@nolde nolde commented Dec 9, 2021

Resolves #57

All tests are passing.

@davidmeirlevy
Copy link
Contributor

Looks great.
Can you add more tests that will cover the new API you added?

@nolde
Copy link
Contributor Author

nolde commented Dec 11, 2021

Sure!

You had tests for map, store+map, and store+namespace+map (the ones using createNamespacedHelpers), so those should still be covered by the existing ones.

I will add some more for namespace+map, which are the only ones missing.

@nolde
Copy link
Contributor Author

nolde commented Dec 11, 2021

Done!

@nolde
Copy link
Contributor Author

nolde commented Dec 17, 2021

Anything else you need from me on this one, @davidmeirlevy ?

@davidmeirlevy davidmeirlevy merged commit 97f2bd9 into greenpress:master Dec 19, 2021
@davidmeirlevy
Copy link
Contributor

@nolde nothing, that's awesome!
I'll publish the new version today.

also, if you can add this ability into the cloned branch of the #55 branch, that will be awesome too (this branch is having this package working for vue3).

@nolde nolde deleted the feature/global-namespaces branch December 19, 2021 22:10
@nolde
Copy link
Contributor Author

nolde commented Dec 19, 2021

Sure,, will take a look at that!

Might take a while longer though, with holidays coming up.

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] In-place namespaces
2 participants