Added AbstractQuery.getDao()

[cwlockhart]

Used to check if the dao database isn't already closed to validate a saved query object.

[greenrobot]

Sorry, don't want to expose that. One can always store the dao beforehand.

[jeffdgr8]

@greenrobot Can you please explain why exposing the dao property would be a problem? Storing the dao alongside a saved query object, when the query object itself already has a reference to it would be a dirty solution to this problem.

The problem that needs to be solved is being able to find out if a saved query object is referencing a database that has already been closed or not. Before attempting to reuse a saved query, this needs to be checked, as it's possible the database has been closed in our app.

Invalidating all saved query objects upon closing the database is also a complicated solution, as we'd have to be sure to add every saved query reference to the database closing method, and it would be easy to forget when adding them later.

It's much easier to make this check before attempting to reuse a query. Is there some other way you could propose knowing if a query object is still reusable with a currently opened database or if it is referencing a database which is no longer open?

[greenrobot]

I was almost convinced, but public AbstractDao<T, ?> getDao() is ugly. It is missing the K (key type). How about getAbstractDaoSession ?

[jeffdgr8]

That should work as well for this need, since ultimately it would be the dao session that would be gotten from the dao to perform this check.

public AbstractDaoSession getSession() {
    return dao.getSession();
}

[cwlockhart]

I've made the requested changes from getDao() to getSession() so the dao is no longer exposed, but we can validate the session before trying to reuse a saved query object.