Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the /add commit to use the authenticated user #87

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Change the /add commit to use the authenticated user #87

merged 1 commit into from
Sep 14, 2024

Conversation

ryanrivest
Copy link
Collaborator

@ryanrivest ryanrivest commented Sep 13, 2024

I believe if we remove the committer parameter, it will use the authenticated user instead, which in this case I believe would be the PR deploy app. The GitHub docs seem to indicate that this field is optional.

image

I'm hoping this change will update the commits when we run an /add some-app command to show up as our PR deploy app instead.

@greggbjensen
Copy link
Owner

Nice catch, thanks! Merging.

@greggbjensen greggbjensen merged commit d40317d into greggbjensen:main Sep 14, 2024
1 check failed
@greggbjensen
Copy link
Owner

greggbjensen commented Sep 14, 2024

Published as release 0.1.8.

@greggbjensen
Copy link
Owner

greggbjensen commented Sep 14, 2024

I have also invited you as a direct contributor, so you will have permissions, and will not need to fork unless you want to.

@greggbjensen greggbjensen added the good first issue Good for newcomers label Sep 14, 2024
@ryanrivest ryanrivest deleted the use-defaults-for-add-committer branch September 14, 2024 19:21
@ryanrivest
Copy link
Collaborator Author

Awesome, thanks Gregg! The fix worked 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants