Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove runc drivers #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove runc drivers #103

wants to merge 1 commit into from

Conversation

philgebhardt
Copy link
Contributor

Background

  • The following drivers are replacements for these runc drivers: containerd-linux, crio-linux, docker-linux
  • These drivers have been released and default for about four months now, and we would like to remove references to the drivers that were replaced.

Change

  • Remove the old runc drivers

## Background

* The following drivers are replacements for these runc drivers: `containerd-linux`, `crio-linux`, `docker-linux`
* These drivers have been released and default for about four months now, and we would like to remove references to the drivers that were replaced.

## Change

* Remove the old runc drivers
@philgebhardt philgebhardt requested review from a team as code owners June 20, 2024 23:52
@@ -81,38 +81,21 @@ gremlin:
container:
# gremlin.container.driver -
# Specifies which container driver with which to run Gremlin. Possible values and their meanings:
# docker = Provides legacy integration with Docker containers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker is still in the dictionary in the helpers template, and container drivers list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants