Update secret.yaml to include parentheses #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parentheses so that 'default' and 'required' are evaluated before the result is passed to the 'toString' function (this will prevent numeric team IDs from throwing an error when installed according to our docs)
richbg
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Change looks good but let's make sure we cover all places for consistency.
- We got teamId/clusterId. Let's get teamSecret too.
- We should cover the integrations chart too: https://github.com/gremlin/helm/blob/master/gremlin-integrations/templates/secret.yaml
We can probably bump each chart's patch version in this PR.
Adding parentheses to teamSecret `toString` interacts with it correctly as it is theoretically vulnerable to the same issue with numeric secrets
drudgesentinel
added a commit
to drudgesentinel/helm
that referenced
this pull request
Sep 18, 2024
updating patch version per: gremlin#110 (review)
drudgesentinel
added a commit
to drudgesentinel/helm
that referenced
this pull request
Sep 18, 2024
Updating chart version per: gremlin#110 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses so that 'default' and 'required' are evaluated before the result is passed to the 'toString' function (this will prevent numeric team IDs from throwing an error when installed according to our docs)