Use isomorphic fetch #4
Open
+7
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request replaces the use of node-fetch with the native fetch API in the Notion SDK for JavaScript, aiming to simplify the codebase and reduce dependencies.
- Increased minimum Node.js version requirement from 12 to 18 in
package.json - Removed
fetchandagentoptions fromClientOptionsinterface insrc/Client.ts - Updated
requestmethod insrc/Client.tsto use globalfetchfunction - Removed
src/fetch-types.tsfile, eliminating custom fetch API type definitions - Updated
errors.tsto use standardHeaderstype instead of customSupportedResponse['headers']
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -3,7 +3,7 @@ | |||
| "version": "2.2.15", | |||
| "description": "A simple and easy to use client for the Notion API", | |||
| "engines": { | |||
| "node": ">=12" | |||
| "node": ">=18" | |||
There was a problem hiding this comment.
logic: Increasing the minimum Node.js version to 18 may break compatibility for users on older versions
There was a problem hiding this comment.
style: Consider adding a comment explaining the transition to native fetch API for future maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
fetchis stable in the current LTS version of Node, I don't see any good reason for using node-fetch or any other solution than the web standard.