Fix Py_UNREACHABLE missing in 3.6

greshilov · Nov 28, 2021 · 2ca987f · 2ca987f
1 parent 0e1dc58
commit 2ca987f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -46,6 +46,11 @@ jobs:
       matrix:
         pyver: ['3.8', '3.9', '3.10']
         os: [ubuntu, macos, windows]
+        include:
+          - pyver: '3.6'
+            os: ubuntu
+          - pyver: '3.7'
+            os: ubuntu
       fail-fast: false
     runs-on: ${{ matrix.os }}-latest
     timeout-minutes: 15

diff --git a/pysegmenttree/_abc.py b/pysegmenttree/_abc.py
@@ -12,7 +12,7 @@ class QueryFunction(Enum):
     MIN = "min"
     MAX = "max"
 
-    @lru_cache
+    @lru_cache()
     def _map(self, value: "QueryFunction"):
         return {
             QueryFunction.SUM: add,

diff --git a/pysegmenttree/_extensions/common.h b/pysegmenttree/_extensions/common.h
@@ -1,6 +1,11 @@
 #define MAX(x, y) (((x) > (y)) ? (x) : (y))
 #define MIN(x, y) (((x) < (y)) ? (x) : (y))
 
+/* Py_UNREACHABLE was introduced only in 3.7 */
+#if !defined Py_UNREACHABLE
+#define Py_UNREACHABLE() Py_FatalError("Unreachable C code path reached")
+#endif
+
 enum QueryFunc {
     Sum = 1,
     Min,