Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 44 get rid of error chain dependency #45

Merged

Conversation

tommady
Copy link
Contributor

@tommady tommady commented Feb 28, 2021

fix #44

Hi, I am a user of this wonderful library,
and currently, I try to use anyhow into my application but causing this error

E0277: `(dyn std::error::Error + std::marker::Send + 'static)` cannot be shared between threads safely  `(dyn std::e
rror::Error + std::marker::Send + 'static)` cannot be shared between threads safely  help: the trait `std::marker::S
ync` is not implemented for `(dyn std::error::Error + std::marker::Send + 'static)` note: required because of the re
quirements on the impl of `std::marker::Sync` for `std::ptr::Unique<(dyn std::error::Error + std::marker::Send + 'st
atic)>` note: required because it appears within the type `std::boxed::Box<(dyn std::error::Error + std::marker::Sen
d + 'static)>` note: required because it appears within the type `std::option::Option<std::boxed::Box<(dyn std::erro
r::Error + std::marker::Send + 'static)>>` note: required because it appears within the type `error_chain::State` no
te: required because it appears within the type `ta::errors::Error` note: required because of the requirements on th
e impl of `std::convert::From<ta::errors::Error>` for `anyhow::Error` note: required by `std::convert::From::from`

and seems like that error is based on this issue from error-chain

then I noticed that you opened an issue try to get rid of that library,
so that's why this PR happened.

hope you will accept it.
thank you.

@greyblake
Copy link
Owner

@tommady , thank you!

@greyblake greyblake merged commit ed13982 into greyblake:master Feb 28, 2021
austin-starks pushed a commit to austin-starks/ta-rs-improved that referenced this pull request May 28, 2024
…r-chain-dependency

Issue 44 get rid of error chain dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of error-chain dependency.
2 participants