Fix AttachDirichletMap type stability #1050
Merged
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `mat` and `vec` are real valued and `vals` is complex valued, we still want to force the `copyto!(vec_with_bcs,vec)` to have a complex valued return type fixes gridap#974
The (0,1) AttachDirichletMap is just (A,b,c) -> c . So we can avoid `mul!` in this case (but keep the `copyto!` for type stability when c is real but b and d=cache[2] are complex). I believe this is safe regarding type stability since `return_cache(::AttachDirichletMap)` uses an eager `Base.*` to create the `cache`, it does not rely on this evaluate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 195 195
Lines 23572 23575 +3
=======================================
+ Hits 20949 20952 +3
Misses 2623 2623 ☔ View full report in Codecov by Sentry. |
JordiManyer
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing copying c values into the cache container d when doing d <- 0Ab +1*c for type stability (in case b is complex but c is real).
Fixes #974
Added the MWE in test/GridapTests/issue_974.jl.