-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Runge-Kutta ODE solver #919
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #919 +/- ##
==========================================
- Coverage 88.44% 88.31% -0.13%
==========================================
Files 191 174 -17
Lines 20652 20397 -255
==========================================
- Hits 18266 18014 -252
+ Misses 2386 2383 -3
... and 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @santiagobadia, @fverdugo, @amartinhuertas, could any of you take a look at this PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oriolcg!
I see that nothing critical outside the ODEs module was changed. So for me, looks good!
Hi @oriolcg , |
In this PR I modified the Runge-Kutta method in
RungeKutta.jl
to accommodateTransientFEOperators
by adding a new operator type namedTransientRungeKuttaFEOperator
. This new type allows for a separate definition of the mass and right-hand side operators, as required by the Runge-Kutta scheme.