Porting to PArrays v0.3 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/gridap/GridapDistributed.jl/blob/424b76c0f4800f6c2d38db68c25d0a560695d90e/README.md running flawlessly for the debug backend
actually need to pass the array with the part/rank identifiers
Renamed towards better readability, encapsulated pieces of reusable code into functions in order to eliminate code replication
except those related to Periodic BCs in CartesianDiscreteModel
|
for the records ... the error with the Periodic BCs is here ... https://github.com/gridap/GridapDistributed.jl/actions/runs/5419584873/jobs/9852831016#step:7:16 |
…partitioned_arrays_v0.3 Conflicts: src/CellData.jl
GridapDistributed
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 10 11 +1
Lines 1694 1982 +288
=======================================
- Misses 1694 1982 +288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For the records, I run all MPI tests on my local machine, and as expected, only the periodic BCs test fails. |
of with_mpi(...) and with_debug(...)
…partitioned_arrays_v0.3 Conflicts: src/CellData.jl src/Interface.jl
This allows access to fine and coarse comms from within the redistribution routines. Got rid of the GridapDistributed void structures which were created for that same purpose.
Redistribute API rework
Bugfix: periodic bcs not working
Removed Manifests
…tributed.jl into bugfix-periodic-bcs
Bugfix: periodic bcs
…tributed.jl into partitioned_arrays_v0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress ...
Left for another future PR: