Merge pull request #22 from nvthongswansea/docs

Update docs and coding convention

gridscale/datasource_gridscale_ipv4_test.go

@@ -14,7 +14,7 @@ func TestAccdataSourceGridscaleIPv4_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleIpv4DestroyCheck,
+		CheckDestroy: testAccCheckGridscaleIpv4DestroyCheck,
 		Steps: []resource.TestStep{
 			{
 

gridscale/datasource_gridscale_ipv6_test.go

@@ -13,7 +13,7 @@ func TestAccdataSourceGridscaleIPv6_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleIpv6DestroyCheck,
+		CheckDestroy: testAccCheckGridscaleIpv6DestroyCheck,
 		Steps: []resource.TestStep{
 			{
 

gridscale/datasource_gridscale_loadbalancer_test.go

@@ -13,7 +13,7 @@ func TestAccdataSourceGridscaleLoadBalancer_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckResourceGridscaleLoadBalancerDestroyCheck,
+		CheckDestroy: testAccCheckGridscaleLoadBalancerDestroyCheck,
 		Steps: []resource.TestStep{
 			{
 

gridscale/datasource_gridscale_network_test.go

@@ -13,7 +13,7 @@ func TestAccdataSourceGridscaleNetwork_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleNetworkDestroyCheck,
+		CheckDestroy: testAccCheckGridscaleNetworkDestroyCheck,
 		Steps: []resource.TestStep{
 			{
 

gridscale/datasource_gridscale_sshkey_test.go

@@ -13,7 +13,7 @@ func TestAccdataSourceGridscaleSSHKey_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleSshkeyDestroyCheck,
+		CheckDestroy: testAccCheckGridscaleSshkeyDestroyCheck,
 		Steps: []resource.TestStep{
 			{
 

gridscale/datasource_gridscale_storage_test.go

@@ -13,7 +13,7 @@ func TestAccdataSourceGridscaleStorage_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleStorageDestroyCheck,
+		CheckDestroy: testAccCheckGridscaleStorageDestroyCheck,
 		Steps: []resource.TestStep{
 			{
 

gridscale/resource_gridscale_ipv4_test.go

@@ -11,27 +11,27 @@ import (
 	"github.com/gridscale/gsclient-go"
 )
 
-func TestAccDataSourceGridscaleIpv4_Basic(t *testing.T) {
+func TestAccResourceGridscaleIpv4_Basic(t *testing.T) {
 	var object gsclient.IP
 	name := fmt.Sprintf("object-%s", acctest.RandString(10))
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleIpv4DestroyCheck,
+		CheckDestroy: testAccCheckGridscaleIpv4DestroyCheck,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCheckDataSourceGridscaleIpv4Config_basic(name),
+				Config: testAccCheckResourceGridscaleIpv4Config_basic(name),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleIpv4Exists("gridscale_ipv4.foo", &object),
+					testAccCheckResourceGridscaleIpv4Exists("gridscale_ipv4.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_ipv4.foo", "name", name),
 				),
 			},
 			{
-				Config: testAccCheckDataSourceGridscaleIpv4Config_basic_update(),
+				Config: testAccCheckResourceGridscaleIpv4Config_basic_update(),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleIpv4Exists("gridscale_ipv4.foo", &object),
+					testAccCheckResourceGridscaleIpv4Exists("gridscale_ipv4.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_ipv4.foo", "name", "newname"),
 					resource.TestCheckResourceAttr(
@@ -44,7 +44,7 @@ func TestAccDataSourceGridscaleIpv4_Basic(t *testing.T) {
 	})
 }
 
-func testAccCheckDataSourceGridscaleIpv4Exists(n string, object *gsclient.IP) resource.TestCheckFunc {
+func testAccCheckResourceGridscaleIpv4Exists(n string, object *gsclient.IP) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
 
@@ -76,7 +76,7 @@ func testAccCheckDataSourceGridscaleIpv4Exists(n string, object *gsclient.IP) re
 	}
 }
 
-func testAccCheckDataSourceGridscaleIpv4DestroyCheck(s *terraform.State) error {
+func testAccCheckGridscaleIpv4DestroyCheck(s *terraform.State) error {
 	client := testAccProvider.Meta().(*gsclient.Client)
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "gridscale_ipv4" {
@@ -100,15 +100,15 @@ func testAccCheckDataSourceGridscaleIpv4DestroyCheck(s *terraform.State) error {
 	return nil
 }
 
-func testAccCheckDataSourceGridscaleIpv4Config_basic(name string) string {
+func testAccCheckResourceGridscaleIpv4Config_basic(name string) string {
 	return fmt.Sprintf(`
 resource "gridscale_ipv4" "foo" {
   name   = "%s"
 }
 `, name)
 }
 
-func testAccCheckDataSourceGridscaleIpv4Config_basic_update() string {
+func testAccCheckResourceGridscaleIpv4Config_basic_update() string {
 	return fmt.Sprintf(`
 resource "gridscale_ipv4" "foo" {
   name   = "newname"

gridscale/resource_gridscale_ipv6_test.go

@@ -11,27 +11,27 @@ import (
 	"github.com/gridscale/gsclient-go"
 )
 
-func TestAccDataSourceGridscaleIpv6_Basic(t *testing.T) {
+func TestAccResourceGridscaleIpv6_Basic(t *testing.T) {
 	var object gsclient.IP
 	name := fmt.Sprintf("object-%s", acctest.RandString(10))
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleIpv6DestroyCheck,
+		CheckDestroy: testAccCheckGridscaleIpv6DestroyCheck,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCheckDataSourceGridscaleIpv6Config_basic(name),
+				Config: testAccCheckResourceGridscaleIpv6Config_basic(name),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleIpv6Exists("gridscale_ipv6.foo", &object),
+					testAccCheckResourceGridscaleIpv6Exists("gridscale_ipv6.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_ipv6.foo", "name", name),
 				),
 			},
 			{
-				Config: testAccCheckDataSourceGridscaleIpv6Config_basic_update(),
+				Config: testAccCheckResourceGridscaleIpv6Config_basic_update(),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleIpv6Exists("gridscale_ipv6.foo", &object),
+					testAccCheckResourceGridscaleIpv6Exists("gridscale_ipv6.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_ipv6.foo", "name", "newname"),
 					resource.TestCheckResourceAttr(
@@ -44,7 +44,7 @@ func TestAccDataSourceGridscaleIpv6_Basic(t *testing.T) {
 	})
 }
 
-func testAccCheckDataSourceGridscaleIpv6Exists(n string, object *gsclient.IP) resource.TestCheckFunc {
+func testAccCheckResourceGridscaleIpv6Exists(n string, object *gsclient.IP) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
 
@@ -76,7 +76,7 @@ func testAccCheckDataSourceGridscaleIpv6Exists(n string, object *gsclient.IP) re
 	}
 }
 
-func testAccCheckDataSourceGridscaleIpv6DestroyCheck(s *terraform.State) error {
+func testAccCheckGridscaleIpv6DestroyCheck(s *terraform.State) error {
 	client := testAccProvider.Meta().(*gsclient.Client)
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "gridscale_ipv6" {
@@ -100,15 +100,15 @@ func testAccCheckDataSourceGridscaleIpv6DestroyCheck(s *terraform.State) error {
 	return nil
 }
 
-func testAccCheckDataSourceGridscaleIpv6Config_basic(name string) string {
+func testAccCheckResourceGridscaleIpv6Config_basic(name string) string {
 	return fmt.Sprintf(`
 resource "gridscale_ipv6" "foo" {
   name   = "%s"
 }
 `, name)
 }
 
-func testAccCheckDataSourceGridscaleIpv6Config_basic_update() string {
+func testAccCheckResourceGridscaleIpv6Config_basic_update() string {
 	return fmt.Sprintf(`
 resource "gridscale_ipv6" "foo" {
   name   = "newname"

gridscale/resource_gridscale_loadbalancer_test.go

@@ -18,7 +18,7 @@ func TestAccResourceGridscaleLoadBalancerBasic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckResourceGridscaleLoadBalancerDestroyCheck,
+		CheckDestroy: testAccCheckGridscaleLoadBalancerDestroyCheck,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccCheckResourceGridscaleLoadBalancerConfig_basic(name, "leastconn"),
@@ -136,7 +136,7 @@ resource "gridscale_loadbalancer" "foo" {
 }`, name, name, name, name, algorithm)
 }
 
-func testAccCheckResourceGridscaleLoadBalancerDestroyCheck(s *terraform.State) error {
+func testAccCheckGridscaleLoadBalancerDestroyCheck(s *terraform.State) error {
 	client := testAccProvider.Meta().(*gsclient.Client)
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "gridscale_loadbalancer" {

gridscale/resource_gridscale_network_test.go

@@ -11,27 +11,27 @@ import (
 	"github.com/gridscale/gsclient-go"
 )
 
-func TestAccDataSourceGridscaleNetwork_Basic(t *testing.T) {
+func TestAccResourceGridscaleNetwork_Basic(t *testing.T) {
 	var object gsclient.Network
 	name := fmt.Sprintf("object-%s", acctest.RandString(10))
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleNetworkDestroyCheck,
+		CheckDestroy: testAccCheckGridscaleNetworkDestroyCheck,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCheckDataSourceGridscaleNetworkConfig_basic(name),
+				Config: testAccCheckResourceGridscaleNetworkConfig_basic(name),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleNetworkExists("gridscale_network.foo", &object),
+					testAccCheckResourceGridscaleNetworkExists("gridscale_network.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_network.foo", "name", name),
 				),
 			},
 			{
-				Config: testAccCheckDataSourceGridscaleNetworkConfig_basic_update(),
+				Config: testAccCheckResourceGridscaleNetworkConfig_basic_update(),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleNetworkExists("gridscale_network.foo", &object),
+					testAccCheckResourceGridscaleNetworkExists("gridscale_network.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_network.foo", "name", "newname"),
 					resource.TestCheckResourceAttr(
@@ -42,7 +42,7 @@ func TestAccDataSourceGridscaleNetwork_Basic(t *testing.T) {
 	})
 }
 
-func testAccCheckDataSourceGridscaleNetworkExists(n string, object *gsclient.Network) resource.TestCheckFunc {
+func testAccCheckResourceGridscaleNetworkExists(n string, object *gsclient.Network) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
 
@@ -74,7 +74,7 @@ func testAccCheckDataSourceGridscaleNetworkExists(n string, object *gsclient.Net
 	}
 }
 
-func testAccCheckDataSourceGridscaleNetworkDestroyCheck(s *terraform.State) error {
+func testAccCheckGridscaleNetworkDestroyCheck(s *terraform.State) error {
 	client := testAccProvider.Meta().(*gsclient.Client)
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "gridscale_network" {
@@ -98,15 +98,15 @@ func testAccCheckDataSourceGridscaleNetworkDestroyCheck(s *terraform.State) erro
 	return nil
 }
 
-func testAccCheckDataSourceGridscaleNetworkConfig_basic(name string) string {
+func testAccCheckResourceGridscaleNetworkConfig_basic(name string) string {
 	return fmt.Sprintf(`
 resource "gridscale_network" "foo" {
   name   = "%s"
 }
 `, name)
 }
 
-func testAccCheckDataSourceGridscaleNetworkConfig_basic_update() string {
+func testAccCheckResourceGridscaleNetworkConfig_basic_update() string {
 	return fmt.Sprintf(`
 resource "gridscale_network" "foo" {
   name   = "newname"

gridscale/resource_gridscale_server_test.go

@@ -11,19 +11,19 @@ import (
 	"github.com/gridscale/gsclient-go"
 )
 
-func TestAccDataSourceGridscaleServer_Basic(t *testing.T) {
+func TestAccResourceGridscaleServer_Basic(t *testing.T) {
 	var object gsclient.Server
 	name := fmt.Sprintf("object-%s", acctest.RandString(10))
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
-		CheckDestroy: testAccCheckDataSourceGridscaleServerDestroyCheck,
+		CheckDestroy: testAccCheckResourceGridscaleServerDestroyCheck,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCheckDataSourceGridscaleServerConfig_basic(name),
+				Config: testAccCheckResourceGridscaleServerConfig_basic(name),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleServerExists("gridscale_server.foo", &object),
+					testAccCheckResourceGridscaleServerExists("gridscale_server.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_server.foo", "name", name),
 					resource.TestCheckResourceAttr(
@@ -35,9 +35,9 @@ func TestAccDataSourceGridscaleServer_Basic(t *testing.T) {
 				),
 			},
 			{
-				Config: testAccCheckDataSourceGridscaleServerConfig_basic_update(),
+				Config: testAccCheckResourceGridscaleServerConfig_basic_update(),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDataSourceGridscaleServerExists("gridscale_server.foo", &object),
+					testAccCheckResourceGridscaleServerExists("gridscale_server.foo", &object),
 					resource.TestCheckResourceAttr(
 						"gridscale_server.foo", "name", "newname"),
 					resource.TestCheckResourceAttr(
@@ -52,7 +52,7 @@ func TestAccDataSourceGridscaleServer_Basic(t *testing.T) {
 	})
 }
 
-func testAccCheckDataSourceGridscaleServerExists(n string, object *gsclient.Server) resource.TestCheckFunc {
+func testAccCheckResourceGridscaleServerExists(n string, object *gsclient.Server) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
 
@@ -84,7 +84,7 @@ func testAccCheckDataSourceGridscaleServerExists(n string, object *gsclient.Serv
 	}
 }
 
-func testAccCheckDataSourceGridscaleServerDestroyCheck(s *terraform.State) error {
+func testAccCheckResourceGridscaleServerDestroyCheck(s *terraform.State) error {
 	client := testAccProvider.Meta().(*gsclient.Client)
 	for _, rs := range s.RootModule().Resources {
 		if rs.Type != "gridscale_server" {
@@ -108,7 +108,7 @@ func testAccCheckDataSourceGridscaleServerDestroyCheck(s *terraform.State) error
 	return nil
 }
 
-func testAccCheckDataSourceGridscaleServerConfig_basic(name string) string {
+func testAccCheckResourceGridscaleServerConfig_basic(name string) string {
 	return fmt.Sprintf(`
 resource "gridscale_server" "foo" {
   name   = "%s"
@@ -119,7 +119,7 @@ resource "gridscale_server" "foo" {
 `, name)
 }
 
-func testAccCheckDataSourceGridscaleServerConfig_basic_update() string {
+func testAccCheckResourceGridscaleServerConfig_basic_update() string {
 	return fmt.Sprintf(`
 resource "gridscale_server" "foo" {
   name   = "newname"