Remove image query drivers/task/engine #1017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
refactor/image-query-cleanup
branch
2 times, most recently
from
5352f38 to
d594028
Compare
|
Don't necessarily need a review on this right now, want to explore a couple things first. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
refactor/image-query-cleanup
branch
from
d594028 to
c019900
Compare
collindutter
force-pushed
the
refactor/image-query-cleanup
branch
from
c019900 to
32c2ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed:
ImageQueryDriverin favor of usingPromptDriverwithTextArtifactandImageArtifactinputs.ImageQueryEngine, in favor of usingPromptDriverdirectly.ImageQueryTask, in favor ofPromptTaskwithTextArtifactandImageArtifactinputs.ImageQueryClientnow takes aPromptDriverinstead of anImageQueryEngine.Issue ticket number and link
NA
📚 Documentation preview 📚: https://griptape--1017.org.readthedocs.build//1017/