Rename all Tools for better naming consistency #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
fix/tool-names
branch
from
6475cbe to
10e3140
Compare
1 task
dylanholmes
previously approved these changes
Aug 13, 2024
Comment on lines
96
to
100
| tools=[ | ||
| WebScraper(off_prompt=True), | ||
| TaskMemoryClient(off_prompt=True), | ||
| FileManager() | ||
| WebScraperTool(off_prompt=True), | ||
| TaskMemoryTool(off_prompt=True), | ||
| FileManagerTool() | ||
| ] |
collindutter
force-pushed
the
fix/tool-names
branch
from
10e3140 to
0fdac5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
fix/tool-names
branch
5 times, most recently
from
9c7eaaa to
fd85735
Compare
collindutter
force-pushed
the
fix/tool-names
branch
from
fd85735 to
0574f0d
Compare
dylanholmes
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed
Clientfrom all Tool names for better naming consistency._clientsuffix from all Tool packages.Toolsuffix to all Tool names for better naming consistency.Was on the fence about dropping
Clientfrom some tools likeSqlClient. But it was unclear when a Tool should, and should not containClientso I decided to drop from all.Issue ticket number and link
NA
📚 Documentation preview 📚: https://griptape--1060.org.readthedocs.build//1060/