-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/drivers config #1086
Refactor/drivers config #1086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the discussedconfig
object be called something else? global_config
or default_config
or something?
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
b78ea45
to
b072929
Compare
b072929
to
77a27e0
Compare
66fab31
to
7bdb00b
Compare
7bdb00b
to
963dcef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only constant is change
Describe your changes
DriverConfig
toDriversConfig
to indicate that it's multiple Drivers in a configuration.griptape.config
togriptape.configs
for consistency with other packages (gritpape.drivers
,griptape.artifacts
, etc).griptape.configs.config._Config
togriptape.configs.defaults_config._DefaultsConfig
.griptape.configs.config
togriptape.configs.defaults_config.Defaults
.griptape.events.event_bus
togriptape.events.EventBus
.griptape.mixins.SingletonMixin
.Issue ticket number and link
Offline discussion
📚 Documentation preview 📚: https://griptape--1086.org.readthedocs.build//1086/