Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/drivers config #1086

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Refactor/drivers config #1086

merged 9 commits into from
Aug 20, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Aug 20, 2024

Describe your changes

  • Rename DriverConfig to DriversConfig to indicate that it's multiple Drivers in a configuration.
  • Rename griptape.config to griptape.configs for consistency with other packages (gritpape.drivers, griptape.artifacts, etc).
  • Rename griptape.configs.config._Config to griptape.configs.defaults_config._DefaultsConfig.
  • Rename griptape.configs.config to griptape.configs.defaults_config.Defaults.
  • Rename griptape.events.event_bus to griptape.events.EventBus.
  • Add griptape.mixins.SingletonMixin.

Issue ticket number and link

Offline discussion


📚 Documentation preview 📚: https://griptape--1086.org.readthedocs.build//1086/

@collindutter collindutter requested a review from vasinov August 20, 2024 15:55
Copy link
Member

@vachillo vachillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the config object be called something else? global_config or default_config or something? discussed

docs/griptape-framework/structures/drivers-configs.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 97.63780% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
griptape/drivers/prompt/base_prompt_driver.py 66.66% 2 Missing ⚠️
griptape/utils/chat.py 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter force-pushed the refactor/drivers-config branch 2 times, most recently from b78ea45 to b072929 Compare August 20, 2024 17:24
@collindutter collindutter force-pushed the refactor/drivers-config branch from b072929 to 77a27e0 Compare August 20, 2024 17:32
@collindutter collindutter requested a review from vachillo August 20, 2024 17:41
@collindutter collindutter force-pushed the refactor/drivers-config branch from 66fab31 to 7bdb00b Compare August 20, 2024 17:55
@collindutter collindutter force-pushed the refactor/drivers-config branch from 7bdb00b to 963dcef Compare August 20, 2024 17:56
Copy link
Member

@vachillo vachillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only constant is change

@collindutter collindutter merged commit 1d84b7f into dev Aug 20, 2024
13 checks passed
@collindutter collindutter deleted the refactor/drivers-config branch August 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants