Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use EventListener as Context Manager #1163

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Sep 9, 2024

Describe your changes

Added

  • Ability to use Event Listeners as Context Managers for temporarily setting the Event Bus listeners.

Issue ticket number and link

NA


📚 Documentation preview 📚: https://griptape--1163.org.readthedocs.build//1163/

vachillo
vachillo previously approved these changes Sep 9, 2024
Comment on lines 17 to 18
_last_event_listeners: Optional[list[EventListener]] = field(default=None)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooops

@collindutter collindutter force-pushed the feature/event-bus-context branch 2 times, most recently from b750fca to 82c9b15 Compare September 9, 2024 20:27
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

vachillo
vachillo previously approved these changes Sep 9, 2024
@collindutter collindutter force-pushed the feature/event-bus-context branch from 38ad801 to 35a4720 Compare September 11, 2024 16:23
dylanholmes
dylanholmes previously approved these changes Sep 11, 2024
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thanks for adding the lock!

dylanholmes
dylanholmes previously approved these changes Sep 11, 2024
@collindutter collindutter merged commit 4bf3d57 into dev Sep 11, 2024
15 checks passed
@collindutter collindutter deleted the feature/event-bus-context branch September 11, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants