Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have EventListener flush batch #1246

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Have EventListener flush batch #1246

merged 7 commits into from
Oct 14, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Oct 9, 2024 •
edited
Loading

Describe your changes

Added

  • BaseEventListener.flush_events() to flush events from an Event Listener.

Changed

  • BREAKING: BaseEventListener.publish_event flush argument. Use BaseEventListener.flush_events() instead.
  • BaseEventListener no longer requires a thread lock for batching events.

Fixed

  • Structures not flushing events when not listening for FinishStructureRunEvent.

Issue ticket number and link

Closes #1244

@collindutter collindutter force-pushed the fix/event-flush branch 2 times, most recently from 3b35ca4 to 9e8d650 Compare October 10, 2024 16:21
@collindutter collindutter marked this pull request as ready for review October 10, 2024 16:23
@collindutter collindutter requested a review from vachillo October 10, 2024 16:23
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ivers/event_listener/base_event_listener_driver.py 86.95% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

vachillo
vachillo reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@vachillo vachillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good pending coverage

CHANGELOG.md Show resolved Hide resolved
@collindutter collindutter force-pushed the fix/event-flush branch 2 times, most recently from dd39c2a to d8940f9 Compare October 10, 2024 18:04
@collindutter
Copy link
Member Author

@vachillo I refactored away changes made in #1104. Do you remember how to test the original issue?

@vachillo
Copy link
Member

@vachillo I refactored away changes made in #1104. Do you remember how to test the original issue?

i do not know how to reproduce that, no

@collindutter collindutter force-pushed the fix/event-flush branch 3 times, most recently from a5de0e3 to 33a00d8 Compare October 10, 2024 20:04
vachillo
vachillo previously approved these changes Oct 11, 2024
View reviewed changes
@collindutter collindutter requested a review from vachillo October 11, 2024 17:23
@collindutter collindutter merged commit a9943fb into dev Oct 14, 2024
15 checks passed
@collindutter collindutter deleted the fix/event-flush branch October 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vachillo vachillo vachillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batched EventListenerDrivers not getting flushed if not listening on FinishStructureRunEvent
2 participants
@collindutter @vachillo