Update EventListener.handler behavior #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vachillo
force-pushed
the
event_listener
branch
from
73f898e to
17e5cb3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
requested changes
Oct 15, 2024
vachillo
force-pushed
the
event_listener
branch
from
d1d6ebb to
b4070eb
Compare
collindutter
previously approved these changes
Oct 15, 2024
vachillo
force-pushed
the
event_listener
branch
from
cc1b23f to
f1d4451
Compare
collindutter
previously approved these changes
Oct 15, 2024
collindutter
force-pushed
the
event_listener
branch
from
289c261 to
1f09a52
Compare
collindutter
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
driveronEventListenertoevent_listener_driver.EventListener.handlerreturn value behavior. IfEventListener.handlerreturnsNone, the event will not be published to theevent_listener_driver.EventListener.handlerreturn type toOptional[BaseEvent | dict].Issue ticket number and link
closes #1130
📚 Documentation preview 📚: https://griptape--1260.org.readthedocs.build//1260/