Update docs for saving/loading drivers configs #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
docs/config-saving
branch
from
123ba73 to
395e14e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
shhlife
reviewed
Dec 12, 2024
dylanholmes
approved these changes
Dec 16, 2024
dylanholmes
reviewed
Dec 16, 2024
Comment on lines
-5
to
-11
| custom_config = AmazonBedrockDriversConfig() | ||
| dict_config = custom_config.to_dict() | ||
| # Use OpenAi for embeddings | ||
| dict_config["embedding_driver"] = { | ||
| "base_url": None, | ||
| "model": "text-embedding-3-small", | ||
| "organization": None, |
There was a problem hiding this comment.
Are there any other docs showing this type of example of manipulating the "json" directly? Or maybe its not needed since why would you do that if you are already using python?
There was a problem hiding this comment.
Yeah this example didn't feel all that necessary to me
collindutter
force-pushed
the
docs/config-saving
branch
from
395e14e to
7ebe75f
Compare
collindutter
force-pushed
the
docs/config-saving
branch
from
7ebe75f to
79ca6c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update docs for saving/loading drivers configs
Issue ticket number and link
Closes #1425
📚 Documentation preview 📚: https://griptape--1436.org.readthedocs.build//1436/