Don't create subtasks when not using tools #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
fix/prompt
branch
from
1948bff to
984629e
Compare
collindutter
commented
Dec 26, 2024
| subtask = self.add_subtask(ActionsSubtask(result.to_artifact())) | ||
| else: | ||
| break | ||
| break |
There was a problem hiding this comment.
Not introduced by this change
dylanholmes
approved these changes
Dec 30, 2024
Comment on lines
+206
to
+209
| if self.tools: | ||
| subtask = self.add_subtask(ActionsSubtask(result.to_artifact())) | ||
|
|
||
| while True: |
There was a problem hiding this comment.
You could avoid some nesting if you flip the condition:
if not self.tools:
self.output = result.to_artifact()
return self.output
while True:
...There was a problem hiding this comment.
I'd rather keep the conditional positive and solve the ugly nested code separately here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Don't create subtasks when not using tools
Issue ticket number and link
Introduced via #1463