Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Agent initialization #1495

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Clean up Agent initialization #1495

merged 2 commits into from
Dec 31, 2024

Conversation

collindutter
Copy link
Member

Describe your changes

Added

  • Validators to Agent initialization.

Fixed

  • Agent.stream overriding Agent.prompt_driver.stream even when Agent.prompt_driver is explicitly provided.

Issue ticket number and link

Closes #1490

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@collindutter collindutter force-pushed the fix/agent-stream branch 3 times, most recently from 442fbf4 to 824efe5 Compare December 31, 2024 00:47
@collindutter collindutter marked this pull request as ready for review December 31, 2024 00:47
Copy link
Contributor

@dylanholmes dylanholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope, but my preference would be to remove the stream flag field from all abstractions and rely on method calls instead.

@collindutter collindutter merged commit 531e91c into main Dec 31, 2024
16 checks passed
@collindutter collindutter deleted the fix/agent-stream branch December 31, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent.stream Overrides Prompt Driver
2 participants