Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ollama Embedding Driver #953

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Add Ollama Embedding Driver #953

merged 1 commit into from
Jul 10, 2024

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Jul 10, 2024

Describe your changes

Adds Ollama Embedding Driver for use with Ollama embedding models.

Issue ticket number and link

https://discord.com/channels/1096466116672487547/1105169591619027055/1254032622959460442


📚 Documentation preview 📚: https://griptape--953.org.readthedocs.build//953/
Closes #1005

@collindutter collindutter requested a review from a team July 10, 2024 15:25
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

cjkindel
cjkindel previously approved these changes Jul 10, 2024
Copy link
Contributor

@cjkindel cjkindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future task to add a OllamaStructureConfig?

@collindutter
Copy link
Member Author

Ah good call, I will update this PR to include that.

@collindutter
Copy link
Member Author

@cjkindel leaving a Structure Config out for this reason.

@collindutter collindutter merged commit c20617a into dev Jul 10, 2024
12 checks passed
@collindutter collindutter deleted the feature/ollama-embedding branch July 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ollama embedding driver support
2 participants