Run ruff on entire project #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
feature/ruff-tests
branch
2 times, most recently
from
c9379fe to
2225ca1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
feature/ruff-tests
branch
from
e8c4e46 to
d71889c
Compare
dylanholmes
requested changes
Jul 16, 2024
Comment on lines
253
to
256
| # loop over the files in the bucket and print them | ||
| response = s3_client.list_objects_v2(Bucket=bucket) | ||
| for obj in response.get("Contents", []): | ||
| print(obj.get("Key")) | ||
| for _obj in response.get("Contents", []): | ||
| pass |
There was a problem hiding this comment.
Maybe just remove this whole section... no reason to loop if you don't print
| @@ -32,8 +32,8 @@ def test_load_collection(self, create_source, loader): | |||
|
|
|||
| assert len(collection) == len(resource_paths) | |||
|
|
|||
| keys = {loader.to_key(source) for source in sources} | |||
| for key in collection.keys(): | |||
| {loader.to_key(source) for source in sources} | |||
There was a problem hiding this comment.
Result of this map comprehension isn't used
collindutter
force-pushed
the
feature/ruff-tests
branch
from
d71889c to
3491a66
Compare
collindutter
force-pushed
the
feature/ruff-tests
branch
from
3491a66 to
2383542
Compare
dylanholmes
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Run ruff on entire project instead of just
griptapedirectory. Also adds flake8-pytest-style.Issue ticket number and link
NA
📚 Documentation preview 📚: https://griptape--986.org.readthedocs.build//986/