Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observability #991

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Add observability #991

merged 6 commits into from
Jul 17, 2024

Conversation

dylanholmes
Copy link
Contributor

@dylanholmes dylanholmes commented Jul 16, 2024 •
edited
Loading

Changes:

  • Merge all observability changes into dev

This PR squashes the following previous PRs and rebases ontop of dev:

Rebasing on dev required quite a few changes due to the ruff rule enforcement additions. (They're good changes though 👍 )

📚 Documentation preview 📚: https://griptape--991.org.readthedocs.build//991/

@dylanholmes dylanholmes force-pushed the feature/observability branch 2 times, most recently from 5fbe2ab to f223a5d Compare July 16, 2024 23:27
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.60630% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...servability/open_telemetry_observability_driver.py 98.24% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@dylanholmes dylanholmes force-pushed the feature/observability branch from f223a5d to fa32077 Compare July 16, 2024 23:58
@dylanholmes dylanholmes marked this pull request as ready for review July 16, 2024 23:58
@dylanholmes dylanholmes requested a review from collindutter July 16, 2024 23:58
@dylanholmes dylanholmes requested a review from cjkindel July 17, 2024 16:59
@cjkindel
Copy link
Contributor

Just code coverage left as far as I am concerned

@dylanholmes
Copy link
Contributor Author

Just code coverage left as far as I am concerned

We hit the target, are there any particular lines you are concerned about?

cjkindel
cjkindel previously approved these changes Jul 17, 2024
View reviewed changes
@dylanholmes dylanholmes force-pushed the feature/observability branch from b18e54a to 842c392 Compare July 17, 2024 17:53
collindutter
collindutter requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just some minor questions/comments.

docs/griptape-framework/drivers/observability-drivers.md Show resolved Hide resolved
docs/griptape-framework/drivers/observability-drivers.md Show resolved Hide resolved
griptape/drivers/event_listener/griptape_cloud_event_listener_driver.py Show resolved Hide resolved
griptape/drivers/observability/griptape_cloud_observability_driver.py Outdated Show resolved Hide resolved
griptape/drivers/observability/griptape_cloud_observability_driver.py Show resolved Hide resolved
griptape/drivers/observability/griptape_cloud_observability_driver.py Show resolved Hide resolved
griptape/drivers/prompt/base_prompt_driver.py Show resolved Hide resolved
griptape/common/__init__.py Show resolved Hide resolved
griptape/tools/base_tool.py Show resolved Hide resolved
collindutter
collindutter approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo 🎉

@dylanholmes dylanholmes merged commit 33469ef into dev Jul 17, 2024
20 checks passed
@dylanholmes dylanholmes deleted the feature/observability branch July 17, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collindutter collindutter collindutter approved these changes

@cjkindel cjkindel cjkindel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanholmes @cjkindel @collindutter