Skip to content

Commit

Permalink
Adds a home directory for non-root docker user in container (#1109)
Browse files Browse the repository at this point in the history
Fixes some edge cases where certain programs (e.g yarn) wouldn't work correctly due to HOME being set to a folder with bad permissions.
  • Loading branch information
Spoffy authored Jul 16, 2024
1 parent 73e022b commit 1d92e69
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions sandbox/docker_entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,20 @@ if [[ $current_user_id == 0 ]]; then
# Make sure the target user owns everything that Grist needs write access to.
find $write_dir ! -user "$target_user" -exec chown "$target_user" "{}" +

# Make a home directory for the target user, in case anything needs to access it.
export HOME="/grist_user_homes/${target_user}"
mkdir -p "$HOME"
chown -R "$target_user":"$target_group" "$HOME"

# Restart as the target user, replacing the current process (replacement is needed for security).
# Alternative tools to setpriv are: chroot, gosu.
# Need to use `exec` to close the parent shell, to avoid vulnerabilities: https://github.com/tianon/gosu/issues/37
exec setpriv --reuid "$target_user" --regid "$target_group" --init-groups /usr/bin/env bash "$0" "$@"
fi

# Printing the user helps with setting volume permissions.
echo "Running Grist as user $(id -u) with primary group $(id -g)"

# Validate that this user has access to the top level of each important directory.
# There might be a benefit to testing individual files, but this is simpler as the dir may start empty.
for dir in "${important_read_dirs[@]}"; do
Expand Down

0 comments on commit 1d92e69

Please sign in to comment.