-
-
Notifications
You must be signed in to change notification settings - Fork 339
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(core) Fix more tests: bundleSize and Embed
Summary: 1. Unclear why Embed fails often. Locally, it fails for me every time, and this tweak makes it pass (while still keeping the test useful). 2. Reduced back main bundle's size by removing dependency of some common elements on the full AdminPanel. Updated expected size of errorPages bundle to the new reduced size. Test Plan: No changes to functionality; relying on existing tests to verify that. Reviewers: jordigh Reviewed By: jordigh Subscribers: georgegevoian, jordigh Differential Revision: https://phab.getgrist.com/D4315
- Loading branch information
Showing
4 changed files
with
14 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Separated out into its own file because this is used in several modules, but we'd like to avoid | ||
// pulling in the full AdminPanel into their bundle. | ||
|
||
import {makeT} from 'app/client/lib/localization'; | ||
|
||
const t = makeT('AdminPanel'); | ||
|
||
// Translated "Admin Panel" name, made available to other modules. | ||
export function getAdminPanelName() { | ||
return t("Admin Panel"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters