Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIM users endpoint #1199

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

fflorent
Copy link
Collaborator

@fflorent fflorent commented Sep 6, 2024

Context

As an IT asset administrator, I can create account of my users using a centralized solution like an SSO so they can log on Grist. It's quite convenient because I don't have to worry about creating accounts specifically for them.

Also Grist handles the update of Users when reconnect.

There are things the administrator cannot do though:

  • assign users to Groups (like the owners of an team site);
  • change immediately user information;
  • delete the user when they are removed from the SSO;
  • get the list of users or groups in a normalized way;
  • ...

Proposed solution

SCIM is a standard proposed by the IETF through RFC7644 and RFC7643 which aims to through a simple Rest API provide solution for the above use cases.

Here is the abstract of the RFC7644 which introduces SCIM:

The System for Cross-domain Identity Management (SCIM) specification is an HTTP-based protocol that makes managing identities in multi-domain scenarios easier to support via a standardized service.
Examples include, but are not limited to, enterprise-to-cloud service providers and inter-cloud scenarios. The specification suite seeks to build upon experience with existing schemas and deployments, placing specific emphasis on simplicity of development and integration, while applying existing authentication, authorization, and privacy models. SCIM's intent is to reduce the cost and complexity of user management operations by providing a common user schema, an extension model, and a service protocol defined by this document.

This PR provides the implementation of SCIM for Users Resources (Group will come in a future PR), and supports:

  • All the basic actions (POST /Users/, PUT /Users/:id, GET /Users/, GET /Users/:id and DELETE /Users/:id).
  • The /Schemas, /ServiceProviderConfig, /ResourceTypes endpoints;
  • The /Me endpoint (it takes advantage of the id you returned in the authentication middleware);
  • The POST /Bulk endpoint
  • The POST /Resources/.search by using the Filters (actually to use them, you must have to fetch all the Resources from the DB, the filtering is done in JS, which is probably fine for small projects, I would just be cautious when using big databases + an ORM);
  • There are some error utilities to help you;
  • The PATCH /Resources/:id endpoint! It reads a resource using the egress method, applies the asked changes, and calls the ingress method to update the record ;
  • The pagination

To do that, I take advantage of two libraries: scimmy and scimmy-routers. Scimmy is lightweight (0 dependency), and scimmy-routers will also be dependency-free be in a future version (reported in that issue and already fixed).

Two variables are introduced:

  • GRIST_ENABLE_SCIM to let the administrator enable the scim API (defaults to false);
  • GRIST_SCIM_EMAIL to let the administrator specify a user that is allowed, they are granted rights to do any operation using SCIM (just like the administrators of GRIST_DEFAULT_EMAIL and GRIST_SUPPORT_EMAIL);

Assumption regarding the SCIM implementation

  • the ID is the technical ID in the database;
  • SCIM's userName corresponds to the normalized email (logins.email), the SCIM emails corresponds to the displayEmail;
  • I don't allow more than an email to be passed (as the Grist code requires currently IIRC);
  • Anonymous users cannot call any SCIM endpoint;
  • Authenticated non-admin and non-GRIST_SCIM_EMAIL users can only request these endpoints;

How to test manually?

I can document the API in grist-help upon request (otherwise I will do that after this PR is merged).

You may:

  1. run a local Grist server setting either the GRIST_DEFAULT_EMAIL, GRIST_SUPPORT_EMAIL or GRIST_SCIM_EMAIL env variable without omitting to enable SCIM using GRIST_ENABLE_SCIM:
GRIST_SCIM_EMAIL="[email protected]" GRIST_ENABLE_SCIM=1 yarn start
  1. Generate a bearer for [email protected]
  2. then you may start using SCIM:
$ export BEARER=<paste the bearer here>
$ curl -H 'Content-Type: application/scim+json' -H "Authorization: Bearer $BEARER" -X POST -d '{"schemas": ["urn:ietf:params:scim:api:messages:2.0:SearchRequest"], "sortBy": "userName", "sortOrder": "descending"}' https://localhost:8484/api/scim/v2/Users/.search

I described some examples of the SCIM API usage here (they need to be adaptated for the context of Grist): https://github.com/scimmyjs/scimmy-routers/blob/8ffa2221b542054c3f0cfb765ea6957f29ebe5e1/example/README.md#play-with-the-scim-server

Limitations of the current implementation

  • The user bearer not renewed automatically, so it does not comply with the request of limiting their lifetime (source);
  • Only an administrator (with the GRIST_DEFAULT_EMAIL or the support account) or the user with GRIST_SCIM_EMAIL are allowed to make operations on resources (other user are limited to use /Me).
  • A dedicated account (like GRIST_SCIM_EMAIL) is required to have access to the endpoints, which should have their API key generated. I considered instead having a bearer directly set in an env variable, but I rejected the idea because it would have been rejected by the Authorizer.
  • The /Me endpoint implementation seems partial (issue);
  • I forgot to add tests for the pagination… I am noting to do that;
  • The SCIMMY and scimmy-routers libraries lack of typing support, so you may see many any types or some casts until that is fixed (issue and issue);
  • [now fixed] The Content-Type must be application/scim+json, currently application/json is not supported (will be fixed in the next scimmy-routers release)

Documentation

I opened this PR in draft to start documenting SCIM: gristlabs/grist-help#434

It can be previewed here:

Related issues

It partly implements #870 (Users resource only for now).

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

test/server/lib/Scim.ts Show resolved Hide resolved
app/gen-server/lib/homedb/UsersManager.ts Outdated Show resolved Hide resolved
app/gen-server/lib/homedb/UsersManager.ts Show resolved Hide resolved
try {
const fakeScope: Scope = { userId: id };
// FIXME: deleteUser should probably better not requiring a scope.
await this._dbManager.deleteUser(fakeScope, id);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like a bit dirty to me to create a fake Scope, but I fear it is hard to get rid of it from UsersManager.deleteUser, especially because the deleteOrg needs it.

Any opinion/idea on that?

@fflorent fflorent marked this pull request as ready for review September 6, 2024 21:46
@fflorent fflorent force-pushed the scim-users-endpoint branch 5 times, most recently from 995cd46 to 6ed0e85 Compare September 12, 2024 12:06
Copy link
Collaborator

@hexaltation hexaltation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge job.
I think It could be great to have a documentation/scim.md file documenting at least :

  • What part of the SCIM RFCs are not yet implemented,
  • What part of the RFCs are "adapted" to work with grist current logic

It could be a huge time saver for administrators of instances when doing the interconnection.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a clear policy about keeping or removing trailing new-lines in the project ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter says nothing 🤷

app/server/lib/scim/v2/ScimUserController.ts Outdated Show resolved Hide resolved
@fflorent
Copy link
Collaborator Author

Thanks @hexaltation for you feedback!

Thanks for this huge job. I think It could be great to have a documentation/scim.md file documenting at least :

* What part of the SCIM RFCs are not yet implemented,

* What part of the RFCs are "adapted" to work with grist current logic

It could be a huge time saver for administrators of instances when doing the interconnection.

I am rather planing on documenting the API in the grist-help repository and probably add a new page to explain how to setup SCIM and what is currently supported.

@jordigh jordigh self-assigned this Sep 25, 2024
@jordigh jordigh added the self-hosting Self-hosting setup that needs some love label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-hosting Self-hosting setup that needs some love
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants