Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Issue 1269: CHANGE css hard coded colors to vars #1270

Merged
merged 1 commit into from
Oct 30, 2024
Merged

FIX Issue 1269: CHANGE css hard coded colors to vars #1270

merged 1 commit into from
Oct 30, 2024

Conversation

hexaltation
Copy link
Collaborator

@hexaltation hexaltation commented Oct 16, 2024 •
edited
Loading

Context

Some color values are hard coded instead of using grist colors vars

Proposed solution

Changing hard coded color values by grist colors variables

Related issues

Fixes #1269

Has this been tested?

  • yes by building a image with custom css overload locally
  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

Screenshot

2024-10-16_11-33_with custom css

@hexaltation hexaltation requested a review from fflorent October 16, 2024 09:34
fflorent
fflorent approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@fflorent fflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an unnecessary extra space to remove, otherwise LGTM

app/client/ui2018/cssVars.ts Show resolved Hide resolved
@hexaltation hexaltation force-pushed the issue-1269-fixing-hardcoded-color-values branch from 8f751df to f3865af Compare October 23, 2024 12:50
@berhalak berhalak self-assigned this Oct 30, 2024
@berhalak berhalak self-requested a review October 30, 2024 16:28
berhalak
berhalak approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hexaltation!

@berhalak berhalak merged commit 8f9521a into gristlabs:main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fflorent fflorent fflorent approved these changes

@berhalak berhalak berhalak approved these changes

Assignees

@berhalak berhalak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TINY] Some colors are hard coded instead of using grist-var-colors.
3 participants
@hexaltation @fflorent @berhalak