Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE node version in .nvmrc to be consistent with #1255 #1371

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

hexaltation
Copy link
Collaborator

@hexaltation hexaltation commented Jan 7, 2025

Context

In #1255 node version was updated to node 22 in CI.
In #1311 node version was updated to node 22 in dockerfile
It seems a good idea to upgrade .nvmrc to such node version too.

Proposed solution

Update of value in .nvmrc

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

Copy link
Collaborator

@fflorent fflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@hexaltation hexaltation requested a review from paulfitz January 7, 2025 16:12
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@paulfitz paulfitz merged commit a1fff81 into gristlabs:main Jan 7, 2025
13 checks passed
@hexaltation hexaltation deleted the update-node-version branch January 7, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants