Adds in linkstate bubbles (with tooltips) #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(ugly and hacky but seems to work)
|
Deployed as https://grist-jv-linkstate-bubbles-tooltips.fly.dev (until 2023-11-05T09:01:46.781Z) |
|
Closing for now, stored link to this in the internal document about linking improvment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #683, adds bubbles to the tops of viewsections to show the current state of linking.
Unlike #683, this PR adds on-hover tooltips.
(The tooltip contents are a bit redundant now, since they just duplicate the info from RighPanel._buildLinkInfo, but having the info available on hover makes it a lot easier to figure out what the linking is doing I think, and would also be a good place to explain if linking is desynced (e.g. rows filtered out through manual filters))