feat: allow using the existing numeric table IDs in the API #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamilleLegeron
changed the title
|
Once this approach is validated, I could look into doing tests, and if you explain to me how to do it, adapt the documentation |
alexmojaki
reviewed
Oct 11, 2023
|
Looks good! Can you add a couple of DocApi tests? |
alexmojaki
approved these changes
Oct 12, 2023
|
Thank you! For the documentation, I think it's just a matter of updating this line:
I think the original description could also be clearer. @dsagal how does this sound?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#679
Realized in this PR
Allow using the existing numeric tableId in the API called tableRef in the code. We change nothing in the API, just allow to used tableRef instead of tableId in the endpoint url