Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Docker tests #724

Merged
merged 1 commit into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/nbrowser/ActionLog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe('ActionLog', function() {
assert.equal(await gu.getActiveCell().getText(), 'f');

// Delete Table1Renamed.
await gu.removeTable('Table1Renamed');
await gu.removeTable('Table1Renamed', {dismissTips: true});
await driver.findContent('.action_log label', /All tables/).find('input').click();

const item4 = await getActionLogItem(4);
Expand Down
2 changes: 1 addition & 1 deletion test/nbrowser/ChoiceList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ describe('ChoiceList', function() {

it('should allow ChoiceList conversions for column used in summary', async function() {
// Add a widget with a summary on column A.
await gu.addNewSection(/Table/, /Table1/, {summarize: [/^A$/]});
await gu.addNewSection(/Table/, /Table1/, {dismissTips: true, summarize: [/^A$/]});
await testTextChoiceListConversions();
await gu.undo();
});
Expand Down
3 changes: 2 additions & 1 deletion test/nbrowser/gristUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1237,8 +1237,9 @@ export async function renameColumn(col: IColHeader|string, newName: string) {
/**
* Removes a table using RAW data view.
*/
export async function removeTable(tableId: string) {
export async function removeTable(tableId: string, options: {dismissTips?: boolean} = {}) {
await driver.find(".test-tools-raw").click();
if (options.dismissTips) { await dismissBehavioralPrompts(); }
const tableIdList = await driver.findAll('.test-raw-data-table-id', e => e.getText());
const tableIndex = tableIdList.indexOf(tableId);
assert.isTrue(tableIndex >= 0, `No raw table with id ${tableId}`);
Expand Down