-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automated update to translation keys #987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
translation-keys
branch
from
May 16, 2024 17:11
a7ddaff
to
bbdeb96
Compare
paulfitz
reviewed
May 16, 2024
static/locales/en.client.json
Outdated
"unknown": "unknown", | ||
"Authentication": "Authentication", | ||
"Current authentication method": "Current authentication method", | ||
"Grist allows different types of authentication to be configured, including SAML and OIDC. We recommend enabling one of these if Grist is accessible over the network or being made available to multiple people.": "Grist allows different types of authentication to be configured, including SAML and OIDC. We recommend enabling one of these if Grist is accessible over the network or being made available to multiple people." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spoffy the translation key looks iffy here. Maybe the spacing should be changed. What do other long keys in the codebase do?
github-actions
bot
force-pushed
the
translation-keys
branch
14 times, most recently
from
May 23, 2024 22:09
9765b4a
to
bae7ec2
Compare
github-actions
bot
force-pushed
the
translation-keys
branch
4 times, most recently
from
May 28, 2024 15:46
37c9c16
to
d9cd3b5
Compare
github-actions
bot
force-pushed
the
translation-keys
branch
from
May 29, 2024 16:11
d9cd3b5
to
8ef0eb0
Compare
Spoffy
added a commit
that referenced
this pull request
May 30, 2024
Updates the authentication message on the admin page, removing newlines and tabs. This cleans up the formatting of the resulting translation key (in `en.client.json`). Context: #987 (comment)
github-actions
bot
force-pushed
the
translation-keys
branch
from
May 30, 2024 14:34
8ef0eb0
to
d2bf60a
Compare
github-actions
bot
force-pushed
the
translation-keys
branch
from
May 31, 2024 01:43
d2bf60a
to
3cf068a
Compare
paulfitz
approved these changes
May 31, 2024
hexaltation
pushed a commit
to hexaltation/grist-core
that referenced
this pull request
Jun 12, 2024
Updates the authentication message on the admin page, removing newlines and tabs. This cleans up the formatting of the resulting translation key (in `en.client.json`). Context: gristlabs#987 (comment)
hexaltation
pushed a commit
to hexaltation/grist-core
that referenced
this pull request
Jun 12, 2024
Co-authored-by: Paul's Grist Bot <[email protected]>
CamilleLegeron
pushed a commit
to incubateur-territoires/grist-core
that referenced
this pull request
Jun 20, 2024
Updates the authentication message on the admin page, removing newlines and tabs. This cleans up the formatting of the resulting translation key (in `en.client.json`). Context: gristlabs#987 (comment)
CamilleLegeron
pushed a commit
to incubateur-territoires/grist-core
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Paul's Grist Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.