Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for self-signed TLS certificates in frontend container #184

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Deprecate support for self-signed TLS certificates in frontend container #184

merged 2 commits into from
Nov 13, 2022

Conversation

jayaddison
Copy link
Contributor

  • Retain support for self-signed certificates in a Containerfile-frontend-tls-selfsigned build file
  • Remove self-signed certificates from the Containerfile-frontend build file

@jayaddison jayaddison mentioned this pull request Nov 12, 2022
Closed
@jayaddison
Copy link
Contributor Author

As explained here, the risk of divergence for the copy of the previous frontend containerfile is acknowledged (and hoped -- although not known -- not to be a maintenance overhead).

@jayaddison jayaddison marked this pull request as ready for review November 13, 2022 13:46
@jayaddison
Copy link
Contributor Author

Moving ahead with this, as I do think that the existing approach to local TLS here should be deprecated.

@jayaddison jayaddison merged commit 1b5ee77 into main Nov 13, 2022
@jayaddison jayaddison deleted the issue-183/selfsigned-tls-optional branch November 13, 2022 15:21
This was referenced Nov 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayaddison