Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Test against new Ruby 2.x #621

Merged
merged 7 commits into from
Feb 6, 2018
Merged

Conversation

nicolasleger
Copy link
Contributor

No description provided.

@nicolasleger
Copy link
Contributor Author

Enhance proposed #583

@nicolasleger
Copy link
Contributor Author

Some tests are passing on my fork https://travis-ci.org/nicolasleger/parallel_tests
Ruby 2.0.0 might be deprecated by some dependencies

@grosser
Copy link
Owner

grosser commented Feb 6, 2018

any chance we can get rid of the test spam in 2.5 ?
https://travis-ci.org/grosser/parallel_tests/jobs/337931187

@grosser
Copy link
Owner

grosser commented Feb 6, 2018

can skip the failing test on 2.0.0 or maybe use a nokogiri version that is 2.0 compatible ?

I guess the test suite in general needs some love to be less brittle :/

PR looks good though!

@nicolasleger
Copy link
Contributor Author

@grosser Thanks, done for the hiding of warning on 2.5 https://travis-ci.org/nicolasleger/parallel_tests/jobs/338083296

@nicolasleger
Copy link
Contributor Author

Nokogiri test config fixed now!
Tests should pass like on my fork CI at https://travis-ci.org/nicolasleger/parallel_tests/builds/338109317

@grosser grosser merged commit 00a9943 into grosser:master Feb 6, 2018
@grosser
Copy link
Owner

grosser commented Feb 6, 2018

awesome, thx! :D

@nicolasleger nicolasleger deleted the ci-new-ruby-2 branch February 6, 2018 18:18
@nicolasleger
Copy link
Contributor Author

Awesome gem! You might restart the failing job on https://travis-ci.org/grosser/parallel_tests/builds/338130632 for the master badge

@grosser
Copy link
Owner

grosser commented Feb 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants