Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined method `tags' for nil:NilClass (NoMethodError) #932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EvgEvg
Copy link

@EvgEvg EvgEvg commented Feb 3, 2024

In case a file is empty, this allows just skipping it rather than breaking the tests run

Error message generated if file is empty also doesn't have file path

/3.2.0/gems/parallel_tests-4.4.0/lib/parallel_tests/cucumber/scenarios.rb:52:in `block in split_into_scenarios': undefined method `tags' for nil:NilClass (NoMethodError)

            feature_tags = feature.tags.map

Checklist

  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • Update Readme.md when cli options are changed

Fix for 

/3.2.0/gems/parallel_tests-4.4.0/lib/parallel_tests/cucumber/scenarios.rb:52:in `block in split_into_scenarios': undefined method `tags' for nil:NilClass (NoMethodError)

            feature_tags = feature.tags.map
@EvgEvg
Copy link
Author

EvgEvg commented Feb 3, 2024

Fix applies for cases if file is just empty

@grosser
Copy link
Owner

grosser commented Feb 3, 2024

nice fix!
can you add a test case for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants