Make the image pushing script safer #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreyEWood
requested review from
tomfaulhaber and
roxanne-o
and removed request for
roxanne-o
honeytung
requested changes
Nov 26, 2024
There was a problem hiding this comment.
This looks good, although I think we should change this script or the inference image build script so that their commands are similar just to be consistent but that is not necessarily for now. Left a comment about support both ARM and x86 images for testing. 🙂
| if [ "$1" == "dev" ]; then | ||
| echo "Received argument 'dev'. Building for current platform only. Latest tag will not be pushed." | ||
| docker build --tag ${EDGE_ENDPOINT_IMAGE} ../.. | ||
| docker tag ${EDGE_ENDPOINT_IMAGE}:latest ${ECR_URL}/${EDGE_ENDPOINT_IMAGE}:${TAG} | ||
| docker push ${ECR_URL}/${EDGE_ENDPOINT_IMAGE}:${TAG} |
There was a problem hiding this comment.
Since we are proposing using dev tag for safer testing, I think we should also make sure that we can build the image for both ARM and x86 so that people testing it out with ARM devices can also run the dev images.
We could just move this portion after the buildx command has initialized the QEMU emulator:
# Build image for amd64 and arm64
docker buildx build \
--platform linux/arm64,linux/amd64 \
--tag ${ECR_URL}/${EDGE_ENDPOINT_IMAGE}:${TAG} \
../.. --push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running the
build-push-edge-endpoint-image.shscript without any arguments would automatically push it to ECR with thelatesttag, which is too easy to accidentally do. With these changes, you must put eitherdevorpush-latestas the argument to make sure you're purposeful with what you're doing.I also updated the workflow to use this arg as well, so pushing a new
latestimage on merge should continue to work. Let me know if that part doesn't look right though.