Re-add support for Kubernetes versions <= v1.23 #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In k8s-wait-for version 2.0, support was dropped for Kubernetes versions 1.23 and earlier. (See https://github.com/groundnuty/k8s-wait-for/releases/tag/v2.0 and #60)
After reviewing the code, it would be simple to continue to support earlier versions. Because we do not care about the Ready value, we do not need to explicitly capture the digit; instead, we can capture the whole
(0 Ready)
string zero or one times. We then ignore the captured value, as we do today.I do appreciate the desire to push people to the latest releases of Kubernetes, but in this case, I believe the extra code required is minimal. It also this simplifies our ability to use the project when we cannot reliably know what k8s version is being used, and prevents people from being locked on k8s-wait-for 1.x.
Changes: