Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module google.golang.org/protobuf to v1.36.1 #5063

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
google.golang.org/protobuf v1.36.0 -> v1.36.1 age adoption passing confidence

Release Notes

protocolbuffers/protobuf-go (google.golang.org/protobuf)

v1.36.1

Compare Source

Full Changelog: protocolbuffers/protobuf-go@v1.36.0...v1.36.1

Bug fixes:
CL/638495: internal/impl: revert IsSynthetic() check to fix panic

Maintenance:
CL/637475: internal/errors: delete compatibility code for Go before 1.13


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot enabled auto-merge (squash) December 16, 2024 19:01
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from ce713ba to b596ac3 Compare December 16, 2024 19:03
@johanbrandhorst
Copy link
Collaborator

Looks like the tests are panicing

@aerialls
Copy link
Contributor

We are also seeing issues since using the protobuf-go 1.36.0. From my investigations, it seems to be linked with optional fields. This is probably caused by https://go-review.googlesource.com/c/protobuf/+/632735 and synthetic oneofs. The code panics at

if f := msgValue.WhichOneof(of); f != nil {
.

Probably the ContainingOneof method should not return synthetic oneofs. Not sure of the fix right now.

@aerialls
Copy link
Contributor

I tried a fix at #5072

@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 55c92e7 to c0055a9 Compare December 17, 2024 17:46
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from c0055a9 to 7a75176 Compare December 17, 2024 17:49
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 7a75176 to 7419e6f Compare December 17, 2024 21:26
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from 7419e6f to 2a194da Compare December 17, 2024 21:30
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 2a194da to 20d86f9 Compare December 18, 2024 04:24
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from 20d86f9 to 1c3f818 Compare December 18, 2024 04:27
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 1c3f818 to f0caf00 Compare December 18, 2024 07:28
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from f0caf00 to f9ceb8c Compare December 18, 2024 07:30
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from f9ceb8c to a903b31 Compare December 18, 2024 14:13
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from a903b31 to 73c6ab1 Compare December 18, 2024 14:15
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 73c6ab1 to 6b5b83a Compare December 18, 2024 16:57
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from 6b5b83a to a90da19 Compare December 18, 2024 17:03
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from a90da19 to 69f1090 Compare December 18, 2024 21:10
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from 69f1090 to ec60043 Compare December 18, 2024 21:16
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from ec60043 to 8e6162c Compare December 19, 2024 01:42
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from 8e6162c to 3c67a8e Compare December 19, 2024 01:45
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 3c67a8e to 035c8c1 Compare December 19, 2024 03:37
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from 035c8c1 to b366984 Compare December 19, 2024 03:40
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from b366984 to c2c133f Compare December 19, 2024 06:46
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from c2c133f to 55f416e Compare December 19, 2024 06:49
@renovate renovate bot changed the title fix(deps): update module google.golang.org/protobuf to v1.36.0 fix(deps): update module google.golang.org/protobuf to v1.36.0 - autoclosed Dec 19, 2024
@renovate renovate bot closed this Dec 19, 2024
auto-merge was automatically disabled December 19, 2024 16:05

Pull request was closed

@renovate renovate bot deleted the renovate/golangprotobuf branch December 19, 2024 16:05
@renovate renovate bot changed the title fix(deps): update module google.golang.org/protobuf to v1.36.0 - autoclosed fix(deps): update module google.golang.org/protobuf to v1.36.0 Dec 23, 2024
@renovate renovate bot reopened this Dec 23, 2024
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 2e4088b to 55f416e Compare December 23, 2024 19:43
@renovate renovate bot changed the title fix(deps): update module google.golang.org/protobuf to v1.36.0 fix(deps): update module google.golang.org/protobuf to v1.36.1 Dec 23, 2024
@renovate renovate bot enabled auto-merge (squash) December 23, 2024 19:46
@renovate renovate bot force-pushed the renovate/golangprotobuf branch from 55f416e to c17a39c Compare December 23, 2024 19:46
@grpcgatewaybot grpcgatewaybot force-pushed the renovate/golangprotobuf branch from c17a39c to 188eed5 Compare December 23, 2024 19:48
@renovate renovate bot merged commit 351f776 into main Dec 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants