Skip to content

Commit

Permalink
bazel: Restore DoNotCall ErrorProne check
Browse files Browse the repository at this point in the history
In e08b9db we added `@DoNotCall` annotations to some call sites, but
Bazel used an older version of ErrorProne that complained at times it
shouldn't. The minimum version of Bazel we test/support is now Bazel 6,
well past Bazel 3.4+.
  • Loading branch information
ejona86 committed Dec 23, 2024
1 parent aafab74 commit 805cad3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion api/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ java_library(
"src/main/java/**/*.java",
"src/context/java/**/*.java",
]),
javacopts = ["-Xep:DoNotCall:OFF"], # Remove once requiring Bazel 3.4.0+; allows non-final
visibility = ["//visibility:public"],
deps = [
artifact("com.google.code.findbugs:jsr305"),
Expand Down
1 change: 0 additions & 1 deletion core/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ java_library(
srcs = glob([
"src/main/java/io/grpc/internal/*.java",
]),
javacopts = ["-Xep:DoNotCall:OFF"], # Remove once requiring Bazel 3.4.0+; allows non-final
resources = glob([
"src/bazel-internal/resources/**",
]),
Expand Down

0 comments on commit 805cad3

Please sign in to comment.