Revert "StatusException/StatusRuntimeException hide stack trace in a simpler way" #11066
Conversation
…simpler …" This reverts commit e36f099.
|
Not needed. EDIT - updated in the next comment. |
|
@panchenko - saw your comment in an email, but not here for some reason.
I think we'd have to roll it back for the moment. Internal linters caught an error in calling super in the constructor: |
|
The public docs make it seem like these exist since API 1. Can that be right? These were added in Java 7, and Android started with Java 6; Java 7 didn't even exist when Android API level 1 was released. But our CI is also not crashing on these. Multiple of the tests should construct an exception: I see a run that passed with API level 22. |
|
Since the thing this was going to revert has been in for 7 months, it seems that reverting is no longer needed. Can we close this PR? |
In 61f19d7 I swapped the signatures to use the version catalog. But I failed to preserve the `@signature` extension and it all seemed to work... But in fact all the animalsniffer tasks were completing as SKIPPED as they lacked signatures. The build.gradle changes in this commit are to fix that while still using version catalog. But while it was broken violations crept in. Most violations weren't too important and we're not surprised went unnoticed. For example, Netty with TLS has long required the Java 8 API `setEndpointIdentificationAlgorithm()`, so using `Optional` in the same code path didn't harm anything in particular. I still swapped it to Guava's `Optional` to avoid overuse of `@IgnoreJRERequirement`. One important violation has not been fixed and instead I've disabled the android signature in api/build.gradle for the moment. The violation is in StatusException using the `fillInStackTrace` overload of Exception. This problem [had been noticed][PR11066], but we couldn't figure out what was going on. AnimalSniffer is now noticing this and agreeing with the internal linter. There is still a question of why our interop tests failed to notice this, but given they are no longer running on pre-API level 24, that may forever be a mystery. [PR11066]: grpc#11066
In 61f19d7 I swapped the signatures to use the version catalog. But I failed to preserve the `@signature` extension and it all seemed to work... But in fact all the animalsniffer tasks were completing as SKIPPED as they lacked signatures. The build.gradle changes in this commit are to fix that while still using version catalog. But while it was broken violations crept in. Most violations weren't too important and we're not surprised went unnoticed. For example, Netty with TLS has long required the Java 8 API `setEndpointIdentificationAlgorithm()`, so using `Optional` in the same code path didn't harm anything in particular. I still swapped it to Guava's `Optional` to avoid overuse of `@IgnoreJRERequirement`. One important violation has not been fixed and instead I've disabled the android signature in api/build.gradle for the moment. The violation is in StatusException using the `fillInStackTrace` overload of Exception. This problem [had been noticed][PR11066], but we couldn't figure out what was going on. AnimalSniffer is now noticing this and agreeing with the internal linter. There is still a question of why our interop tests failed to notice this, but given they are no longer running on pre-API level 24, that may forever be a mystery. [PR11066]: #11066
Internal linters caught an error in calling super in the constructor:
Call requires API level 24 (current min is 19): new java.lang.Exception.Reverts #11064.
Internal ref cl/621317657.