Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xds fallback #11254

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Xds fallback #11254

wants to merge 28 commits into from

Commits on Aug 13, 2024

  1. Checkpoint

    larry-safran committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    25aa454 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    d8f7094 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    d0e7ba2 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    c2f0ecc View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Change logic based on changing from assuming that fallback servers ha…

    …d completely disjoint resource names to assuming that any duplicate names would be compatible, particularly cross authority.
    larry-safran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2ab47a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38267d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    05d188f View commit details
    Browse the repository at this point in the history
  2. Cleanup as recommended

    larry-safran committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dedb8fe View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Remove ControlPlaneClient from resource and instead use authority to …

    …figure out the current CPC.
    
    Add all live ControlPlaneClients to active list rather than skipping ones in backoff.
    Changed isConnected() logic to be based on AdsStream call's success or failure
    larry-safran committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    22b5a0c View commit details
    Browse the repository at this point in the history
  2. Restore experimental property in @after of test

    Fix fallback logic for new watch triggering fallback to use the right CPC.
    Some non-functional clarity improvement
    Change hasSubscribers detection to be across all types and not trying to involve any logic in ControlPlaneClient.
    larry-safran committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    003348b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c11225 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7323f25 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. When response have been received, don't consider it an error when the…

    … ADS stream gets an error. Retry after error is an error.
    larry-safran committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    fe384a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d2e4d8 View commit details
    Browse the repository at this point in the history
  3. Change internalHandleStreamReady() to onl add to activeCpClients when…

    … there hasn't been an active client for that authority rather than using the generic add method all of the time.
    larry-safran committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    23b6740 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b5d69d3 View commit details
    Browse the repository at this point in the history
  5. Don't recalculate which server was deletion ignored from in onAbsent,…

    … instead use locally available value.
    larry-safran committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5b28d7a View commit details
    Browse the repository at this point in the history
  6. when a CPC is bumped by a higher priority server coming up, but is st…

    …ill in the list for some other authority, call adjustResourceSubscriptions on all resource types.
    larry-safran committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    1169f39 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    8d22cfd View commit details
    Browse the repository at this point in the history
  2. Simplify getOrCreateControlPlaneClient of a list by relying on the ve…

    …rsion that takes a single serverInfo.
    larry-safran committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    023c6cd View commit details
    Browse the repository at this point in the history
  3. In handleStreamClosed used the response handler's stored ServerInfo t…

    …o lookup the ControlPlaneClient instead of sending it
    larry-safran committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    517bcc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    230c18d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    7975051 View commit details
    Browse the repository at this point in the history
  2. Create a manageControlPlaneClients() method to wrap usages of getOrCr…

    …eateControlPlaneClient and do fallback.
    
    Move some logic into watchXdsResource from private methods, such as doFallbackIfNecessary, and streamline the execution.
    Stop storing serverInfos in ResourceSubscriber and just construct it from authority as needed.
    larry-safran committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5c6b524 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    b979d70 View commit details
    Browse the repository at this point in the history
  2. Rename activeCpClients to activatedCpClients to avoid overloading the…

    … term 'active'.
    
    Minor change to stream ready process to avoid sending discovery requests multiple times if the CPC was supporting multiple authorities.
    larry-safran committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5a2e071 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Change getOrCreateControlPlaneClient to throw an exception rather tha…

    …n return a null to better match the name.
    
    Do some cleanup
    larry-safran committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5df91a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34a7b83 View commit details
    Browse the repository at this point in the history