Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2a: fix flake in FakeS2AServerTest #11673

Merged
merged 3 commits into from
Nov 8, 2024
Merged

s2a: fix flake in FakeS2AServerTest #11673

merged 3 commits into from
Nov 8, 2024

Conversation

rmehta19
Copy link
Contributor

@rmehta19 rmehta19 commented Nov 6, 2024

While here:

  • add an awaitTermination to after calling shutdown on server
  • don't use port picker

@rmehta19 rmehta19 mentioned this pull request Nov 6, 2024
Closed
@ejona86 ejona86 changed the title fix flake in FakeS2AServerTest. s2a: fix flake in FakeS2AServerTest Nov 8, 2024
ejona86
ejona86 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that we're shutting down the channel before we're checking the response, but I can believe this fixes the flake.

@ejona86
Copy link
Member

ejona86 commented Nov 8, 2024

Fixes #11648

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 8, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 8, 2024
@ejona86 ejona86 merged commit 546efd7 into grpc:master Nov 8, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmehta19 @ejona86 @grpc-kokoro