Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS E2E test flakiness #46

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix TLS E2E test flakiness #46

merged 2 commits into from
Dec 12, 2024

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Dec 11, 2024

Some of the E2E tests with TLS enabled were flaky on Darwin.

This PR:

  • Slightly modifies the way they are implemented to make them not-flaky
  • Modifies the options passed to SecPKCS12Import to make sure the creation of the required SecIdentity happens in memory only and doesn't use the keychain
  • Tolerates a broken pipe error when the server fails client cert validation during an mTLS handshake, as it's possible for Network.framework to expose this error instead of the actual SSL validation error on the client

@gjcairo gjcairo requested a review from glbrntt December 11, 2024 17:07
@gjcairo gjcairo added the semver/none No version bump required. label Dec 11, 2024
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @gjcairo!

@glbrntt
Copy link
Collaborator

glbrntt commented Dec 11, 2024

@gjcairo FYI formatter is unhappy

@gjcairo gjcairo enabled auto-merge (squash) December 12, 2024 11:34
@gjcairo gjcairo merged commit e76bc65 into grpc:main Dec 12, 2024
22 of 28 checks passed
@gjcairo gjcairo deleted the fix-e2e-tests branch December 12, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants