Reset go away state #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The pick first load balancer keeps track of whether the current subchannel is going away. This is done so that if there isn't yet a subchannel to roll over too it won't be offered up when the GRPCChannel asks for a subchannel. However, this state wasn't reset in enough places within the state machine. Modifications: - Reset the is-going-away state when updating the current subchannel and when the current subchannel becomes idle Result: Resolves grpc#40
glbrntt
commented
Dec 18, 2024
| @@ -307,6 +308,7 @@ final class PickFirstLoadBalancerTests: XCTestCase { | |||
| // Must only be connected to server 2 now. | |||
| XCTAssertEqual(context.servers[0].server.clients.count, 0) | |||
| XCTAssertEqual(context.servers[1].server.clients.count, 1) | |||
| XCTAssertNotNil(context.loadBalancer.pickSubchannel()) | |||
There was a problem hiding this comment.
Without the fix this returns nil even though a connection is ready and available to use.
gjcairo
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The pick first load balancer keeps track of whether the current subchannel is going away. This is done so that if there isn't yet a subchannel to roll over too it won't be offered up when the GRPCChannel asks for a subchannel. However, this state wasn't reset in enough places within the state machine.
Modifications:
Result:
Resolves #40