Fix keepalive logic #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Dec 20, 2024
Sources/GRPCNIOTransportCore/Server/Connection/ServerConnectionManagementHandler.swift
Show resolved
Hide resolved
Tests/GRPCNIOTransportCoreTests/Server/GRPCServerStreamHandlerTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportCoreTests/Server/GRPCServerStreamHandlerTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportCoreTests/Server/GRPCServerStreamHandlerTests.swift
Outdated
Show resolved
Hide resolved
glbrntt
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes grpc/grpc-swift#2095.
Motivation
As per the gRPC specification, the server must keep track of pings from each client, and if they go over a threshold, we must send a GOAWAY frame and close the connection. We must reset the number of ping strikes every time the server writes a headers or data frame. However, there is a bug in the current keepalive implementation and we are not properly keeping track of when header/data frames are written, so we never reset the strikes, causing the server to always end up closing connections when keepalive pings are enabled.
There was also a second bug where the GOAWAY frame wasn't actually sent to the client because we were closing the connection straight away, and the packet never made it out.
Modifications
This PR fixes a couple of bugs:
Results
Fewer bugs!