Check for nonexistent targets #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Well, that was a helpful response. Thanks @jsf-clabot. |
|
FWIW, I have manually tested this in the repository in which I initially noticed the cycle, and it is working. |
|
I would really like to see this merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #406. However, I do have questions.
I'm not positive that
grunt.fail.fatalis the right approach. Maybe it should just do nothing and move on to the next task?I've never used nodeunit and am finding writing a test for this a bit intimidating. Can someone help me understand how to get started?
I understand that I need to sign the CLA to contribute. However, the link on gruntjs.com/contributing goes to an info page saying DojoFoundation is now part of JSFoundation, and I can't find a place to sign and submit on JSFoundation. I may have already done this (I've done grunt-contrib PRs before I think), but I'm also not sure where to check for that.