bootstrap: allow user to override BIN_DIR & USER_DATA_DIR #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tiny enhancement allows a user to specify alternate locations for the binaries and user-data. Overriding these values to a location where the user has write privileges will allow this script to run without root permissions. It is probably an uncommon use case, and an advanced user should quickly notice these optional overrides when reviewing the script since they're at the very beginning. For this reason, I did not add a CLI parameter nor documentation.
thinkmassive
requested review from
brikis98,
zackproser and
denis256
as code owners
denis256
reviewed
Apr 27, 2023
| @@ -20,8 +20,8 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| readonly BIN_DIR="/usr/local/bin" | |||
| readonly USER_DATA_DIR="/etc/user-data" | |||
| readonly BIN_DIR="${GRUNTWORK_BIN_DIR:-/usr/local/bin}" | |||
There was a problem hiding this comment.
I was wondering if having an integration test will be helpful here, to keep track that overrides are still working overtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tiny enhancement allows a user to specify alternate locations for the binaries and user-data. Overriding these values to a location where the user has write privileges will allow this script to run without root permissions.
It is probably an uncommon use case, and an advanced user should quickly notice these optional overrides when reviewing the script since they're at the very beginning. For this reason, I did not add a CLI parameter nor documentation.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added optional overrides for BIN_DIR and USER_DATA_DIR
Migration Guide
not applicable