Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 266: Add more examples for SensorData #300

Closed
wants to merge 3 commits into from

Conversation

mkotoff
Copy link

@mkotoff mkotoff commented Jun 21, 2021

No description provided.

@VladimirAlexiev
Copy link
Contributor

VladimirAlexiev commented Jun 21, 2021

Resolves #266 and #292.
@mkotoff:

  • When you're done with the comments, assign to Craig to recompute the ni: hashes of JSON, then regenerate Turtle
  • "ex:component": "ex:x" is wrong, should be "component": "cbv:comp-X"

Copy link
Contributor

@VladimirAlexiev VladimirAlexiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflect the new examples in README

},
"@graph": [
{
"@id": "ni:///sha-256;77c5b495d391767b1d3b8e7c669c9fee3965a778a9bfe793e85602c971b98436?ver=CBV2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start from an existing JSON example and use id, isA, action etc instead of @id, @type, epcis:action etc

"epcis:component": "Latitude",
"epcis:value": {
"@value": "42.698334",
"@type": "http://www.w3.org/2001/XMLSchema#decimal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type is predefined in the context, so use the pure value

"@type": "http://www.w3.org/2001/XMLSchema#decimal"
},
"epcis:uom": "DD",
"epcis:coordinateReferenceSystem:": "http://www.opengis.net/def/crs/OGC/1.3/CRS84"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong trailing :

epcis:readPoint <urn:epc:id:sgln:4012345.00005.0> ;
epcis:sensorElementList [ epcis:sensorMetadata [ epcis:time "2021-05-20T12:23:34+00:00"^^xsd:dateTime
] ;
epcis:sensorReport [ epcis:type 'Angle' ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regenerate Turtle from JSON.

  • use consistent quotes " not '
  • datatype ^^xsd:double is missing
  • epcis:type is wrong, should be epcis:measurementType

@VladimirAlexiev
Copy link
Contributor

@mkotoff:

  • I've picked up all examples (and the extra line in epcis-context) and put them in my series of PRs.
  • Please salvage only Ontology/EPCIS.ttl from here (which has a conflict), see the comments about it above! Submit as a new PR

@CraigRe please close this without merging

@VladimirAlexiev
Copy link
Contributor

@CraigRe please close this without merging

@CraigRe
Copy link
Collaborator

CraigRe commented Sep 21, 2021

Closed without merging.

@CraigRe CraigRe closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants