Merge pull request solidusio#4250 from ccarruitero/shipment-split

fix backbone shipment item view when split

backend/app/assets/javascripts/spree/backend/shipments.js

@@ -180,7 +180,7 @@ var ShipmentItemView = Backbone.View.extend({
     Spree.ajax({
       type: "GET",
       url: Spree.pathFor('api/variants/' + this.variant_id),
-    }).success(function(variant){
+    }).done(function(variant){
       var split = new ShipmentSplitItemView({
         shipmentItemView: _this,
         shipment_number: _this.shipment_number,

backend/spec/features/admin/orders/shipments_spec.rb

@@ -142,4 +142,24 @@ def ship_shipment
       end
     end
   end
+
+  context "when split shipment", js: true do
+    let(:location_name) { "WA Warehouse" }
+    let!(:location) { create(:stock_location, name: location_name)}
+
+    it "can split item" do
+      visit spree.edit_admin_order_path(order)
+      find_all('.split-item').first.click
+      within '.stock-item-split' do
+        find('.save-split').click
+        alert_text = page.driver.browser.switch_to.alert.text
+        expect(alert_text).to include 'Please select the split destination'
+        page.driver.browser.switch_to.alert.accept
+        find('.select2-container').click
+        find(:xpath, '//body').all('.select2-drop li.select2-result', text: "#{location_name} (0 on hand)")[1].click
+        find('.save-split').click
+      end
+      expect(page).to have_content /Pending package from '#{location_name}'/i
+    end
+  end
 end